Unify 2F_85 and 2F_140 link names #67
Closed
+47
−47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #67 +/- ##
==========================================
+ Coverage 0.00% 40.26% +40.26%
==========================================
Files 5 20 +15
Lines 352 524 +172
Branches 0 33 +33
==========================================
+ Hits 0 211 +211
+ Misses 352 308 -44
- Partials 0 5 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
JafarAbdi
reviewed
Sep 27, 2024
| @@ -44,7 +44,7 @@ | |||
|
|
|||
| <!-- Joint interfaces --> | |||
| <!-- With Gazebo or Hardware, they handle mimic joints, so we only need this command interface activated --> | |||
| <joint name="${prefix}robotiq_85_left_knuckle_joint"> | |||
| <joint name="${prefix}left_knuckle_joint"> | |||
There was a problem hiding this comment.
These changes would break existing setups, right? Should we update the default prefix value to robotiq_85_?
|
LGTM, just need to make sure these changes won't break someone's setup |
JafarAbdi
approved these changes
Oct 4, 2024
|
not merging since I think this is breaking current functionality, will reraise after more testing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unification change name.
Hope to fix #66